summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorHangyu Hua <hbh25y@gmail.com>2022-09-21 17:27:34 +0800
committerJakub Kicinski <kuba@kernel.org>2022-09-22 07:04:47 -0700
commitc2e1cfefcac35e0eea229e148c8284088ce437b5 (patch)
tree701ba9fedfd653a6aaa4ece3614062b54cac2150 /net
parent878e2405710aacfeeb19364c300f38b7a9abfe8f (diff)
downloadlinux-c2e1cfefcac35e0eea229e148c8284088ce437b5.tar.bz2
net: sched: fix possible refcount leak in tc_new_tfilter()
tfilter_put need to be called to put the refount got by tp->ops->get to avoid possible refcount leak when chain->tmplt_ops != NULL and chain->tmplt_ops != tp->ops. Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Vlad Buslov <vladbu@nvidia.com> Link: https://lore.kernel.org/r/20220921092734.31700-1-hbh25y@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
-rw-r--r--net/sched/cls_api.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 790d6809be81..51d175f3fbcb 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -2137,6 +2137,7 @@ replay:
}
if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) {
+ tfilter_put(tp, fh);
NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind");
err = -EINVAL;
goto errout;