summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorSean Anderson <seanga2@gmail.com>2022-09-20 19:50:18 -0400
committerJakub Kicinski <kuba@kernel.org>2022-09-22 06:44:28 -0700
commit878e2405710aacfeeb19364c300f38b7a9abfe8f (patch)
treea120773899525b861b99c3deda5ed2acaae0f773 /net
parentdb39dfdc1c3bd9da273902da12f01973792ff911 (diff)
downloadlinux-878e2405710aacfeeb19364c300f38b7a9abfe8f.tar.bz2
net: sunhme: Fix packet reception for len < RX_COPY_THRESHOLD
There is a separate receive path for small packets (under 256 bytes). Instead of allocating a new dma-capable skb to be used for the next packet, this path allocates a skb and copies the data into it (reusing the existing sbk for the next packet). There are two bytes of junk data at the beginning of every packet. I believe these are inserted in order to allow aligned DMA and IP headers. We skip over them using skb_reserve. Before copying over the data, we must use a barrier to ensure we see the whole packet. The current code only synchronizes len bytes, starting from the beginning of the packet, including the junk bytes. However, this leaves off the final two bytes in the packet. Synchronize the whole packet. To reproduce this problem, ping a HME with a payload size between 17 and 214 $ ping -s 17 <hme_address> which will complain rather loudly about the data mismatch. Small packets (below 60 bytes on the wire) do not have this issue. I suspect this is related to the padding added to increase the minimum packet size. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Sean Anderson <seanga2@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20220920235018.1675956-1-seanga2@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions