diff options
author | Jeff Vander Stoep <jeffv@google.com> | 2020-10-23 16:37:57 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2020-10-26 16:22:42 -0700 |
commit | af545bb5ee53f5261db631db2ac4cde54038bdaf (patch) | |
tree | 7df760039a60bee30a6e8b623fa302be93e91b39 /virt | |
parent | 937d8420588421eaa5c7aa5c79b26b42abb288ef (diff) | |
download | linux-af545bb5ee53f5261db631db2ac4cde54038bdaf.tar.bz2 |
vsock: use ns_capable_noaudit() on socket create
During __vsock_create() CAP_NET_ADMIN is used to determine if the
vsock_sock->trusted should be set to true. This value is used later
for determing if a remote connection should be allowed to connect
to a restricted VM. Unfortunately, if the caller doesn't have
CAP_NET_ADMIN, an audit message such as an selinux denial is
generated even if the caller does not want a trusted socket.
Logging errors on success is confusing. To avoid this, switch the
capable(CAP_NET_ADMIN) check to the noaudit version.
Reported-by: Roman Kiryanov <rkir@google.com>
https://android-review.googlesource.com/c/device/generic/goldfish/+/1468545/
Signed-off-by: Jeff Vander Stoep <jeffv@google.com>
Reviewed-by: James Morris <jamorris@linux.microsoft.com>
Link: https://lore.kernel.org/r/20201023143757.377574-1-jeffv@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions