diff options
author | Anssi Hannula <anssi.hannula@bitwise.fi> | 2022-10-10 17:08:27 +0200 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2022-10-11 08:50:44 +0200 |
commit | cd7f30e174d09a02ca2afa5ef093fb0f0352e0d8 (patch) | |
tree | 9bea702835493aeea235f28809ca7d921d71f97d /usr | |
parent | 1499ecaea9d2ba68d5e18d80573b4561a8dc4ee7 (diff) | |
download | linux-cd7f30e174d09a02ca2afa5ef093fb0f0352e0d8.tar.bz2 |
can: kvaser_usb: Fix use of uninitialized completion
flush_comp is initialized when CMD_FLUSH_QUEUE is sent to the device and
completed when the device sends CMD_FLUSH_QUEUE_RESP.
This causes completion of uninitialized completion if the device sends
CMD_FLUSH_QUEUE_RESP before CMD_FLUSH_QUEUE is ever sent (e.g. as a
response to a flush by a previously bound driver, or a misbehaving
device).
Fix that by initializing flush_comp in kvaser_usb_init_one() like the
other completions.
This issue is only triggerable after RX URBs have been set up, i.e. the
interface has been opened at least once.
Cc: stable@vger.kernel.org
Fixes: aec5fb2268b7 ("can: kvaser_usb: Add support for Kvaser USB hydra family")
Tested-by: Jimmy Assarsson <extja@kvaser.com>
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
Link: https://lore.kernel.org/all/20221010150829.199676-3-extja@kvaser.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions