diff options
| author | Quentin Monnet <quentin@isovalent.com> | 2021-10-22 10:47:43 +0100 |
|---|---|---|
| committer | Andrii Nakryiko <andrii@kernel.org> | 2021-10-22 16:44:56 -0700 |
| commit | e89ef634f81c9d90e1824ab183721f3b361472e6 (patch) | |
| tree | 1eec7ee66d53cc820e11d78009bb21087e0dc7b2 /tools/lib | |
| parent | 59f2a29c04128a46df0031d4deb4c4b07c5edcea (diff) | |
| download | linux-e89ef634f81c9d90e1824ab183721f3b361472e6.tar.bz2 | |
bpftool: Avoid leaking the JSON writer prepared for program metadata
Bpftool creates a new JSON object for writing program metadata in plain
text mode, regardless of metadata being present or not. Then this writer
is freed if any metadata has been found and printed, but it leaks
otherwise. We cannot destroy the object unconditionally, because the
destructor prints an undesirable line break. Instead, make sure the
writer is created only after we have found program metadata to print.
Found with valgrind.
Fixes: aff52e685eb3 ("bpftool: Support dumping metadata")
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20211022094743.11052-1-quentin@isovalent.com
Diffstat (limited to 'tools/lib')
0 files changed, 0 insertions, 0 deletions