diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-07-05 08:06:17 -0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-07-05 16:09:11 +0100 |
| commit | f7ddff54d0a0f068442414b48bec7f22aa777de7 (patch) | |
| tree | d817fda89891e42886fdcc396b87d78e6a8d6962 /sound/soc/codecs/nau8824.c | |
| parent | 90eb6b59d311e6facd040124cb5b659a865125b8 (diff) | |
| download | linux-f7ddff54d0a0f068442414b48bec7f22aa777de7.tar.bz2 | |
ASoC: nau8824: use 64-bit arithmetic instead of 32-bit
Add suffix ULL to constant 256 in order to give the compiler complete
information about the proper arithmetic to use.
Notice that such constant is used in a context that expects an
expression of type u64 (64 bits, unsigned) and the following
expression is currently being evaluated using 32-bit arithmetic:
256 * fs * 2 * mclk_src_scaling[i].param
Addresses-Coverity-ID: 1432039 ("Unintentional integer overflow")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/nau8824.c')
| -rw-r--r-- | sound/soc/codecs/nau8824.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 6bd14453f06e..468d5143e2c4 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1274,7 +1274,7 @@ static int nau8824_calc_fll_param(unsigned int fll_in, fvco_max = 0; fvco_sel = ARRAY_SIZE(mclk_src_scaling); for (i = 0; i < ARRAY_SIZE(mclk_src_scaling); i++) { - fvco = 256 * fs * 2 * mclk_src_scaling[i].param; + fvco = 256ULL * fs * 2 * mclk_src_scaling[i].param; if (fvco > NAU_FVCO_MIN && fvco < NAU_FVCO_MAX && fvco_max < fvco) { fvco_max = fvco; |