diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2021-10-03 15:22:54 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-04 15:55:24 +0100 |
| commit | 1cf2aa665901054b140eb71748661ceae99b6b5a (patch) | |
| tree | 2854cae6ddd43a9b54bf37c709171159aa61ac27 /sound/soc/codecs/es8316.c | |
| parent | aab1ad11d69fa7f35cb88105614ea7911598e1d6 (diff) | |
| download | linux-1cf2aa665901054b140eb71748661ceae99b6b5a.tar.bz2 | |
ASoC: es8316: Use IRQF_NO_AUTOEN when requesting the IRQ
Use the new IRQF_NO_AUTOEN flag when requesting the IRQ, rather then
disabling it immediately after requesting it.
This fixes a possible race where the IRQ might trigger between requesting
and disabling it; and this also leads to a small code cleanup.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211003132255.31743-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/es8316.c')
| -rw-r--r-- | sound/soc/codecs/es8316.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index 067757d1d70a..5fb02635c140 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -811,12 +811,9 @@ static int es8316_i2c_probe(struct i2c_client *i2c_client, mutex_init(&es8316->lock); ret = devm_request_threaded_irq(dev, es8316->irq, NULL, es8316_irq, - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, + IRQF_TRIGGER_HIGH | IRQF_ONESHOT | IRQF_NO_AUTOEN, "es8316", es8316); - if (ret == 0) { - /* Gets re-enabled by es8316_set_jack() */ - disable_irq(es8316->irq); - } else { + if (ret) { dev_warn(dev, "Failed to get IRQ %d: %d\n", es8316->irq, ret); es8316->irq = -ENXIO; } |