diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-06-08 16:05:30 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-06-09 17:30:26 +0200 |
| commit | f9a6bb841f737015aface3ba4ac845e66542850e (patch) | |
| tree | 4ea091922c864e6dbc5b75c4117357f293f1ccf0 /sound/core/seq/seq_virmidi.c | |
| parent | 51c816fdd17c63352b04e67c6c5ccaa3417f39aa (diff) | |
| download | linux-f9a6bb841f737015aface3ba4ac845e66542850e.tar.bz2 | |
ALSA: seq: Fix assignment in if condition
There are lots of places doing assignments in if condition in ALSA
sequencer core, which is a bad coding style that may confuse readers
and occasionally lead to bugs.
This patch is merely for coding-style fixes, no functional changes.
Link: https://lore.kernel.org/r/20210608140540.17885-57-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core/seq/seq_virmidi.c')
| -rw-r--r-- | sound/core/seq/seq_virmidi.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/sound/core/seq/seq_virmidi.c b/sound/core/seq/seq_virmidi.c index 77d7037d1476..4abc38c70cae 100644 --- a/sound/core/seq/seq_virmidi.c +++ b/sound/core/seq/seq_virmidi.c @@ -482,10 +482,11 @@ int snd_virmidi_new(struct snd_card *card, int device, struct snd_rawmidi **rrmi int err; *rrmidi = NULL; - if ((err = snd_rawmidi_new(card, "VirMidi", device, - 16, /* may be configurable */ - 16, /* may be configurable */ - &rmidi)) < 0) + err = snd_rawmidi_new(card, "VirMidi", device, + 16, /* may be configurable */ + 16, /* may be configurable */ + &rmidi); + if (err < 0) return err; strcpy(rmidi->name, rmidi->id); rdev = kzalloc(sizeof(*rdev), GFP_KERNEL); |