summaryrefslogtreecommitdiffstats
path: root/sound/aoa/core
diff options
context:
space:
mode:
authorNicholas Mc Guire <hofrat@osadl.org>2018-06-29 19:07:42 +0200
committerTakashi Iwai <tiwai@suse.de>2018-06-29 20:35:14 +0200
commit222bce5eb88d1af656419db04bcd84b2419fb900 (patch)
tree248d76c3c68be1182a2126c75b77fe52bb82f365 /sound/aoa/core
parentfdd49c510021d389bf5979282193e084f328e031 (diff)
downloadlinux-222bce5eb88d1af656419db04bcd84b2419fb900.tar.bz2
ALSA: snd-aoa: add of_node_put() in error path
Both calls to of_find_node_by_name() and of_get_next_child() return a node pointer with refcount incremented thus it must be explicidly decremented here after the last usage. As we are assured to have a refcounted np either from the initial of_find_node_by_name(NULL, name); or from the of_get_next_child(gpio, np) in the while loop if we reached the error code path below, an x of_node_put(np) is needed. Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> Fixes: commit f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/aoa/core')
-rw-r--r--sound/aoa/core/gpio-feature.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/aoa/core/gpio-feature.c b/sound/aoa/core/gpio-feature.c
index 71960089e207..65557421fe0b 100644
--- a/sound/aoa/core/gpio-feature.c
+++ b/sound/aoa/core/gpio-feature.c
@@ -88,8 +88,10 @@ static struct device_node *get_gpio(char *name,
}
reg = of_get_property(np, "reg", NULL);
- if (!reg)
+ if (!reg) {
+ of_node_put(np);
return NULL;
+ }
*gpioptr = *reg;