diff options
author | Florian Fainelli <f.fainelli@gmail.com> | 2020-06-19 11:47:46 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-06-19 13:39:00 -0700 |
commit | 5a8d7f126c97d04d893f5e5be2b286437a0d01b0 (patch) | |
tree | 32fbb132c1fdc53a753d18f0b7ab2c605975fb08 /net | |
parent | 6564cfefb01c4c5b8c357f300feac5cb1585e1a9 (diff) | |
download | linux-5a8d7f126c97d04d893f5e5be2b286437a0d01b0.tar.bz2 |
of: of_mdio: Correct loop scanning logic
Commit 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()")
introduced a break of the loop on the premise that a successful
registration should exit the loop. The premise is correct but not to
code, because rc && rc != -ENODEV is just a special error condition,
that means we would exit the loop even with rc == -ENODEV which is
absolutely not correct since this is the error code to indicate to the
MDIO bus layer that scanning should continue.
Fix this by explicitly checking for rc = 0 as the only valid condition
to break out of the loop.
Fixes: 209c65b61d94 ("drivers/of/of_mdio.c:fix of_mdiobus_register()")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions