diff options
| author | Mordechay Goodstein <mordechay.goodstein@intel.com> | 2019-05-29 15:25:31 +0300 | 
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2019-06-14 15:46:33 +0200 | 
| commit | 1a473d6092d5d182914bea854ce0b21e6d12519d (patch) | |
| tree | 94a251b4a42d7e7b84d46948387cd78bf5b7e034 /net/wireless | |
| parent | f8891461a277ec0afc493fd30cd975a38048a038 (diff) | |
| download | linux-1a473d6092d5d182914bea854ce0b21e6d12519d.tar.bz2 | |
cfg80211: util: fix bit count off by one
The bits of Rx MCS Map in VHT capability were enumerated
with index transform - index i -> (i + 1) bit => nss i. BUG!
while it should be -   index i -> (i + 1) bit => (i + 1) nss.
The bug was exposed in commit a53b2a0b1245 ("iwlwifi: mvm: implement VHT
extended NSS support in rs.c"), where iwlwifi started using the
function.
Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Fixes: b0aa75f0b1b2 ("ieee80211: add new VHT capability fields/parsing")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
| -rw-r--r-- | net/wireless/util.c | 2 | 
1 files changed, 1 insertions, 1 deletions
diff --git a/net/wireless/util.c b/net/wireless/util.c index b9d8ceb21327..1c39d6a2e850 100644 --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -1998,7 +1998,7 @@ int ieee80211_get_vht_max_nss(struct ieee80211_vht_cap *cap,  			continue;  		if (supp >= mcs_encoding) { -			max_vht_nss = i; +			max_vht_nss = i + 1;  			break;  		}  	}  |