summaryrefslogtreecommitdiffstats
path: root/net/sched
diff options
context:
space:
mode:
authorPaolo Abeni <pabeni@redhat.com>2021-01-19 17:56:56 +0100
committerJakub Kicinski <kuba@kernel.org>2021-01-19 18:40:40 -0800
commit00b229f762b020eebf55a52b984aec76ae0ad966 (patch)
tree968d5b2e7ea5b3a40dfe048de6666b1a443768b2 /net/sched
parentfc6f89dd8c55cc756ebeff3d496218a2fbad3ec6 (diff)
downloadlinux-00b229f762b020eebf55a52b984aec76ae0ad966.tar.bz2
net: fix GSO for SG-enabled devices
The commit dbd50f238dec ("net: move the hsize check to the else block in skb_segment") introduced a data corruption for devices supporting scatter-gather. The problem boils down to signed/unsigned comparison given unexpected results: if signed 'hsize' is negative, it will be considered greater than a positive 'len', which is unsigned. This commit addresses resorting to the old checks order, so that 'hsize' never has a negative value when compared with 'len'. v1 -> v2: - reorder hsize checks instead of explicit cast (Alex) Bisected-by: Matthieu Baerts <matthieu.baerts@tessares.net> Fixes: dbd50f238dec ("net: move the hsize check to the else block in skb_segment") Signed-off-by: Paolo Abeni <pabeni@redhat.com> Reviewed-by: Xin Long <lucien.xin@gmail.com> Link: https://lore.kernel.org/r/861947c2d2d087db82af93c21920ce8147d15490.1611074818.git.pabeni@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sched')
0 files changed, 0 insertions, 0 deletions