diff options
author | Arnd Bergmann <arnd@arndb.de> | 2020-04-29 21:00:41 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2020-04-29 21:17:57 +0200 |
commit | c165d57b552aaca607fa5daf3fb524a6efe3c5a3 (patch) | |
tree | cb7007f33e04965077d04e6df65b3829cded2d2b /net/rose | |
parent | ea64d8d6c675c0bb712689b13810301de9d8f77a (diff) | |
download | linux-c165d57b552aaca607fa5daf3fb524a6efe3c5a3.tar.bz2 |
netfilter: nf_osf: avoid passing pointer to local var
gcc-10 points out that a code path exists where a pointer to a stack
variable may be passed back to the caller:
net/netfilter/nfnetlink_osf.c: In function 'nf_osf_hdr_ctx_init':
cc1: warning: function may return address of local variable [-Wreturn-local-addr]
net/netfilter/nfnetlink_osf.c:171:16: note: declared here
171 | struct tcphdr _tcph;
| ^~~~~
I am not sure whether this can happen in practice, but moving the
variable declaration into the callers avoids the problem.
Fixes: 31a9c29210e2 ("netfilter: nf_osf: add struct nf_osf_hdr_ctx")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/rose')
0 files changed, 0 insertions, 0 deletions