diff options
author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-05-07 13:50:41 -0500 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2020-05-07 22:49:28 -0400 |
commit | 0090c1edebf464f34629e14ae03d764cca7e0a3b (patch) | |
tree | 2de91045595375101b2bf66701664d9ca60a7f30 /net/netfilter/xt_limit.c | |
parent | db9ff6ecf6efa6ffc45bfd5dc8d5708cfe5e89cb (diff) | |
download | linux-0090c1edebf464f34629e14ae03d764cca7e0a3b.tar.bz2 |
audit: Replace zero-length array with flexible-array
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'net/netfilter/xt_limit.c')
0 files changed, 0 insertions, 0 deletions