diff options
| author | Paolo Abeni <pabeni@redhat.com> | 2019-02-15 18:15:37 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-02-15 20:25:26 -0800 |
| commit | 1490ed2abc4fa4d7fa6e8498b9fa4243a6ce7f8a (patch) | |
| tree | 704af066c03cc803efcd38c86a3d571fa050a756 /net/ipv6/route.c | |
| parent | 59e6158acafa2fc80160d8a8241c2a715fe89cff (diff) | |
| download | linux-1490ed2abc4fa4d7fa6e8498b9fa4243a6ce7f8a.tar.bz2 | |
net/ipv6: prefer rcu_access_pointer() over rcu_dereference()
rt6_cache_allowed_for_pmtu() checks for rt->from presence, but
it does not access the RCU protected pointer. We can use
rcu_access_pointer() and clean-up the code a bit. No functional
changes intended.
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/route.c')
| -rw-r--r-- | net/ipv6/route.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index dc066fdf7e46..87a0561136dd 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2277,14 +2277,8 @@ static void rt6_do_update_pmtu(struct rt6_info *rt, u32 mtu) static bool rt6_cache_allowed_for_pmtu(const struct rt6_info *rt) { - bool from_set; - - rcu_read_lock(); - from_set = !!rcu_dereference(rt->from); - rcu_read_unlock(); - return !(rt->rt6i_flags & RTF_CACHE) && - (rt->rt6i_flags & RTF_PCPU || from_set); + (rt->rt6i_flags & RTF_PCPU || rcu_access_pointer(rt->from)); } static void __ip6_rt_update_pmtu(struct dst_entry *dst, const struct sock *sk, |