diff options
author | Ross Lagerwall <ross.lagerwall@citrix.com> | 2019-01-17 15:34:38 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-01-18 14:05:14 -0800 |
commit | 6c57f0458022298e4da1729c67bd33ce41c14e7a (patch) | |
tree | c56bc8518423b39cabbda138327a313262ea1e9e /net/ipv4 | |
parent | e40e2a2e78664fa90ea4b9bdf4a84efce2fea9d9 (diff) | |
download | linux-6c57f0458022298e4da1729c67bd33ce41c14e7a.tar.bz2 |
net: Fix usage of pskb_trim_rcsum
In certain cases, pskb_trim_rcsum() may change skb pointers.
Reinitialize header pointers afterwards to avoid potential
use-after-frees. Add a note in the documentation of
pskb_trim_rcsum(). Found by KASAN.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/ip_input.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c index 26921f6b3b92..51d8efba6de2 100644 --- a/net/ipv4/ip_input.c +++ b/net/ipv4/ip_input.c @@ -488,6 +488,7 @@ static struct sk_buff *ip_rcv_core(struct sk_buff *skb, struct net *net) goto drop; } + iph = ip_hdr(skb); skb->transport_header = skb->network_header + iph->ihl*4; /* Remove any debris in the socket control block */ |