diff options
author | Fei Li <lifei.shirley@bytedance.com> | 2019-06-17 21:26:36 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-06-18 10:46:52 -0700 |
commit | 72b319dc08b4924a29f5e2560ef6d966fa54c429 (patch) | |
tree | 5b903ccecff7da043c98ae8242c2e7f86374cdc2 /net/ipv4/ip_tunnel_core.c | |
parent | d0bae4a0e3d8c5690a885204d7eb2341a5b4884d (diff) | |
download | linux-72b319dc08b4924a29f5e2560ef6d966fa54c429.tar.bz2 |
tun: wake up waitqueues after IFF_UP is set
Currently after setting tap0 link up, the tun code wakes tx/rx waited
queues up in tun_net_open() when .ndo_open() is called, however the
IFF_UP flag has not been set yet. If there's already a wait queue, it
would fail to transmit when checking the IFF_UP flag in tun_sendmsg().
Then the saving vhost_poll_start() will add the wq into wqh until it
is waken up again. Although this works when IFF_UP flag has been set
when tun_chr_poll detects; this is not true if IFF_UP flag has not
been set at that time. Sadly the latter case is a fatal error, as
the wq will never be waken up in future unless later manually
setting link up on purpose.
Fix this by moving the wakeup process into the NETDEV_UP event
notifying process, this makes sure IFF_UP has been set before all
waited queues been waken up.
Signed-off-by: Fei Li <lifei.shirley@bytedance.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_tunnel_core.c')
0 files changed, 0 insertions, 0 deletions