diff options
author | Matt Johnston <matt@codeconstruct.com.au> | 2021-10-14 16:10:50 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-10-15 11:22:08 +0100 |
commit | 0b93aed2842d950e8d2625e975e5a57febeff33d (patch) | |
tree | 69a36266a237fb8f644c999888d9cf40abd3f450 /net/ipv4/inet_connection_sock.c | |
parent | bf1366734b362c7da4933760c4f42c278ce843fa (diff) | |
download | linux-0b93aed2842d950e8d2625e975e5a57febeff33d.tar.bz2 |
mctp: Avoid leak of mctp_sk_key
mctp_key_alloc() returns a key already referenced.
The mctp_route_input() path receives a packet for a bind socket and
allocates a key. It passes the key to mctp_key_add() which takes a
refcount and adds the key to lists. mctp_route_input() should then
release its own refcount when setting the key pointer to NULL.
In the mctp_alloc_local_tag() path (for mctp_local_output()) we
similarly need to unref the key before returning (mctp_reserve_tag()
takes a refcount and adds the key to lists).
Fixes: 73c618456dc5 ("mctp: locking, lifetime and validity changes for sk_keys")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/inet_connection_sock.c')
0 files changed, 0 insertions, 0 deletions