diff options
author | Xin Long <lucien.xin@gmail.com> | 2021-05-03 04:41:20 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-05-03 13:32:12 -0700 |
commit | f282df0391267fb2b263da1cc3233aa6fb81defc (patch) | |
tree | 2a53a0dcf0b9f4340a9f5e80e95274335037fd00 /net/hsr/hsr_forward.c | |
parent | a52445ae5a3a4cbfa6380583eea2abf997ae45d1 (diff) | |
download | linux-f282df0391267fb2b263da1cc3233aa6fb81defc.tar.bz2 |
sctp: fix a SCTP_MIB_CURRESTAB leak in sctp_sf_do_dupcook_b
Normally SCTP_MIB_CURRESTAB is always incremented once asoc enter into
ESTABLISHED from the state < ESTABLISHED and decremented when the asoc
is being deleted.
However, in sctp_sf_do_dupcook_b(), the asoc's state can be changed to
ESTABLISHED from the state >= ESTABLISHED where it shouldn't increment
SCTP_MIB_CURRESTAB. Otherwise, one asoc may increment MIB_CURRESTAB
multiple times but only decrement once at the end.
I was able to reproduce it by using scapy to do the 4-way shakehands,
after that I replayed the COOKIE-ECHO chunk with 'peer_vtag' field
changed to different values, and SCTP_MIB_CURRESTAB was incremented
multiple times and never went back to 0 even when the asoc was freed.
This patch is to fix it by only incrementing SCTP_MIB_CURRESTAB when
the state < ESTABLISHED in sctp_sf_do_dupcook_b().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/hsr/hsr_forward.c')
0 files changed, 0 insertions, 0 deletions