summaryrefslogtreecommitdiffstats
path: root/net/dsa
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2022-11-16 11:52:04 +0100
committerJakub Kicinski <kuba@kernel.org>2022-11-17 19:40:08 -0800
commitb8790661d90d7bbfb745df40262d13a0e8ae6400 (patch)
tree8ce8c6fb4230c98dfa7d7e474143c8962d20f779 /net/dsa
parent6fdb038420407d9781b2ba2429f836434a25e91a (diff)
downloadlinux-b8790661d90d7bbfb745df40262d13a0e8ae6400.tar.bz2
net: dsa: set name_assign_type to NET_NAME_ENUM for enumerated user ports
When a user port does not have a label in device tree, and we thus fall back to the eth%d scheme, the proper constant to use is NET_NAME_ENUM. See also commit e9f656b7a214 ("net: ethernet: set default assignment identifier to NET_NAME_ENUM"), which in turn quoted commit 685343fc3ba6 ("net: add name_assign_type netdev attribute"): ... when the kernel has given the interface a name using global device enumeration based on order of discovery (ethX, wlanY, etc) ... are labelled NET_NAME_ENUM. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Florian Fainelli <f.faineli@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/dsa')
-rw-r--r--net/dsa/slave.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 5405b730eb92..24d8ad36fc8b 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -2380,7 +2380,7 @@ int dsa_slave_create(struct dsa_port *port)
assign_type = NET_NAME_PREDICTABLE;
} else {
name = "eth%d";
- assign_type = NET_NAME_UNKNOWN;
+ assign_type = NET_NAME_ENUM;
}
slave_dev = alloc_netdev_mqs(sizeof(struct dsa_slave_priv), name,