diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2020-02-06 20:49:12 +0000 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2020-02-17 21:24:13 +0200 |
| commit | e543e370ec3160c06c2cd897477150dfb23f1afd (patch) | |
| tree | a987df0fca5efa09971f1e29674f582f74e28dc4 /net/core/dev.c | |
| parent | 2e0a576511f656933adfe56ef03b9cf3e64b21b7 (diff) | |
| download | linux-e543e370ec3160c06c2cd897477150dfb23f1afd.tar.bz2 | |
drm/i915/gt: Prevent queuing retire workers on the virtual engine
Virtual engines are fleeting. They carry a reference count and may be freed
when their last request is retired. This makes them unsuitable for the
task of housing engine->retire.work so assert that it is not used.
Tvrtko tracked down an instance where we did indeed violate this rule.
In virtual_submit_request, we flush a completed request directly with
__i915_request_submit and this causes us to queue that request on the
veng's breadcrumb list and signal it. Leading us down a path where we
should not attach the retire.
Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: dc93c9b69315 ("drm/i915/gt: Schedule request retirement when signaler idles")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200206204915.2636606-1-chris@chris-wilson.co.uk
(cherry picked from commit f91d8156ab8afb32447cd2bf3189219bab943f18)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'net/core/dev.c')
0 files changed, 0 insertions, 0 deletions