summaryrefslogtreecommitdiffstats
path: root/net/ceph
diff options
context:
space:
mode:
authorIlya Dryomov <idryomov@gmail.com>2019-08-30 17:38:31 +0200
committerIlya Dryomov <idryomov@gmail.com>2020-03-30 12:42:41 +0200
commitbb0e681dda33adac516dd74723b757c5c2feafe6 (patch)
tree801194158c65ed87a73743229eae4fc492e5a523 /net/ceph
parent4d8b8fb4940a46f8d64bf1f9d116e1d2ae32b01c (diff)
downloadlinux-bb0e681dda33adac516dd74723b757c5c2feafe6.tar.bz2
libceph: directly skip to the end of redirect reply
Coverity complains about a double write to *p. Don't bother with osd_instructions and directly skip to the end of redirect reply. Reported-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Diffstat (limited to 'net/ceph')
-rw-r--r--net/ceph/osd_client.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index f9ec6a6568bd..998e26b75a78 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -3483,9 +3483,6 @@ static int ceph_redirect_decode(void **p, void *end,
goto e_inval;
}
- len = ceph_decode_32(p);
- *p += len; /* skip osd_instructions */
-
/* skip the rest */
*p = struct_end;
out: