summaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorYe Bin <yebin10@huawei.com>2022-12-08 10:32:33 +0800
committerTheodore Ts'o <tytso@mit.edu>2022-12-09 00:57:01 -0500
commite4db04f7d3dbbe16680e0ded27ea2a65b10f766a (patch)
treeec23bd3356550155ee1565f9c0d07186ee50ff77 /mm
parentcc12a6f25e07ed05d5825a1664b67a970842b2ca (diff)
downloadlinux-e4db04f7d3dbbe16680e0ded27ea2a65b10f766a.tar.bz2
ext4: fix inode leak in ext4_xattr_inode_create() on an error path
There is issue as follows when do setxattr with inject fault: [localhost]# fsck.ext4 -fn /dev/sda e2fsck 1.46.6-rc1 (12-Sep-2022) Pass 1: Checking inodes, blocks, and sizes Pass 2: Checking directory structure Pass 3: Checking directory connectivity Pass 4: Checking reference counts Unattached zero-length inode 15. Clear? no Unattached inode 15 Connect to /lost+found? no Pass 5: Checking group summary information /dev/sda: ********** WARNING: Filesystem still has errors ********** /dev/sda: 15/655360 files (0.0% non-contiguous), 66755/2621440 blocks This occurs in 'ext4_xattr_inode_create()'. If 'ext4_mark_inode_dirty()' fails, dropping i_nlink of the inode is needed. Or will lead to inode leak. Signed-off-by: Ye Bin <yebin10@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20221208023233.1231330-5-yebin@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions