diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2014-12-22 12:48:42 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2015-08-13 12:32:00 -0600 |
| commit | 6cf66b4caf9c71f64a5486cadbd71ab58d0d4307 (patch) | |
| tree | 2ef51364e875b99fa4ce42f9edc15147450034d1 /mm | |
| parent | 8ae126660fddbeebb9251a174e6fa45b6ad8f932 (diff) | |
| download | linux-6cf66b4caf9c71f64a5486cadbd71ab58d0d4307.tar.bz2 | |
fs: use helper bio_add_page() instead of open coding on bi_io_vec
Call pre-defined helper bio_add_page() instead of open coding for
iterating through bi_io_vec[]. Doing that, it's possible to make some
parts in filesystems and mm/page_io.c simpler than before.
Acked-by: Dave Kleikamp <shaggy@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lin <ming.l@ssi.samsung.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/page_io.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/mm/page_io.c b/mm/page_io.c index 338ce68942a0..b995a5ba5e8f 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -33,12 +33,10 @@ static struct bio *get_swap_bio(gfp_t gfp_flags, if (bio) { bio->bi_iter.bi_sector = map_swap_page(page, &bio->bi_bdev); bio->bi_iter.bi_sector <<= PAGE_SHIFT - 9; - bio->bi_io_vec[0].bv_page = page; - bio->bi_io_vec[0].bv_len = PAGE_SIZE; - bio->bi_io_vec[0].bv_offset = 0; - bio->bi_vcnt = 1; - bio->bi_iter.bi_size = PAGE_SIZE; bio->bi_end_io = end_io; + + bio_add_page(bio, page, PAGE_SIZE, 0); + BUG_ON(bio->bi_iter.bi_size != PAGE_SIZE); } return bio; } |