diff options
author | Julian Wiedmann <jwi@linux.ibm.com> | 2019-12-23 15:03:21 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-12-24 22:41:06 -0800 |
commit | 8b5026bc16938920e4780b9094c3bf20e1e0939d (patch) | |
tree | 0e3ffc39d7c01e00de4e4f7157eed457b35ec923 /lib/sbitmap.c | |
parent | 47d0b2fe23d840ecbfc187d9ef0ee9e1a229a332 (diff) | |
download | linux-8b5026bc16938920e4780b9094c3bf20e1e0939d.tar.bz2 |
s390/qeth: fix qdio teardown after early init error
qeth_l?_set_online() goes through a number of initialization steps, and
on any error uses qeth_l?_stop_card() to tear down the residual state.
The first initialization step is qeth_core_hardsetup_card(). When this
fails after having established a QDIO context on the device
(ie. somewhere after qeth_mpc_initialize()), qeth_l?_stop_card() doesn't
shut down this QDIO context again (since the card state hasn't
progressed from DOWN at this stage).
Even worse, we then call qdio_free() as final teardown step to free the
QDIO data structures - while some of them are still hooked into wider
QDIO infrastructure such as the IRQ list. This is inevitably followed by
use-after-frees and other nastyness.
Fix this by unconditionally calling qeth_qdio_clear_card() to shut down
the QDIO context, and also to halt/clear any pending activity on the
various IO channels.
Remove the naive attempt at handling the teardown in
qeth_mpc_initialize(), it clearly doesn't suffice and we're handling it
properly now in the wider teardown code.
Fixes: 4a71df50047f ("qeth: new qeth device driver")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/sbitmap.c')
0 files changed, 0 insertions, 0 deletions