summaryrefslogtreecommitdiffstats
path: root/lib/idr.c
diff options
context:
space:
mode:
authorPetr Machata <petrm@mellanox.com>2019-02-04 14:50:38 +0000
committerDavid S. Miller <davem@davemloft.net>2019-02-04 09:19:14 -0800
commitc1f7e02979edd7a3a3e69fe04be60b1d650dc8a7 (patch)
treebac6808b818e8f8c8c544934f93a52cfde26cfb7 /lib/idr.c
parent3e5a7c981464fd592f10a62c911001c174d46c12 (diff)
downloadlinux-c1f7e02979edd7a3a3e69fe04be60b1d650dc8a7.tar.bz2
net: cls_flower: Remove filter from mask before freeing it
In fl_change(), when adding a new rule (i.e. fold == NULL), a driver may reject the new rule, for example due to resource exhaustion. By that point, the new rule was already assigned a mask, and it was added to that mask's hash table. The clean-up path that's invoked as a result of the rejection however neglects to undo the hash table addition, and proceeds to free the new rule, thus leaving a dangling pointer in the hash table. Fix by removing fnew from the mask's hash table before it is freed. Fixes: 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules also under skip_sw") Signed-off-by: Petr Machata <petrm@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Reviewed-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/idr.c')
0 files changed, 0 insertions, 0 deletions