summaryrefslogtreecommitdiffstats
path: root/lib/argv_split.c
diff options
context:
space:
mode:
authorDavid Jeffery <djeffery@redhat.com>2021-07-15 17:37:44 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-21 09:12:12 +0200
commit0b60557230adfdeb8164e0b342ac9cd469a75759 (patch)
treee2673a7abd94b2e8012cb0360bad5f975dd01209 /lib/argv_split.c
parent1b7f56fbc7a1b66967b6114d1b5f5a257c3abae6 (diff)
downloadlinux-0b60557230adfdeb8164e0b342ac9cd469a75759.tar.bz2
usb: ehci: Prevent missed ehci interrupts with edge-triggered MSI
When MSI is used by the ehci-hcd driver, it can cause lost interrupts which results in EHCI only continuing to work due to a polling fallback. But the reliance of polling drastically reduces performance of any I/O through EHCI. Interrupts are lost as the EHCI interrupt handler does not safely handle edge-triggered interrupts. It fails to ensure all interrupt status bits are cleared, which works with level-triggered interrupts but not the edge-triggered interrupts typical from using MSI. To fix this problem, check if the driver may have raced with the hardware setting additional interrupt status bits and clear status until it is in a stable state. Fixes: 306c54d0edb6 ("usb: hcd: Try MSI interrupts on PCI devices") Tested-by: Laurence Oberman <loberman@redhat.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: David Jeffery <djeffery@redhat.com> Link: https://lore.kernel.org/r/20210715213744.GA44506@redhat Cc: stable <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/argv_split.c')
0 files changed, 0 insertions, 0 deletions