diff options
| author | Jeremy Kerr <jk@codeconstruct.com.au> | 2022-07-09 11:19:57 +0800 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2022-07-11 17:13:09 -0600 |
| commit | 3d6e44623841c8b82c2157f2f749019803fb238a (patch) | |
| tree | 1e1cc8314627520cc6f398fc684b5f3ac7a61fad /kernel/module | |
| parent | 8370b400f5abad168bcc541fa2574e7bd6b3bf2c (diff) | |
| download | linux-3d6e44623841c8b82c2157f2f749019803fb238a.tar.bz2 | |
kunit: unify module and builtin suite definitions
Currently, KUnit runs built-in tests and tests loaded from modules
differently. For built-in tests, the kunit_test_suite{,s}() macro adds a
list of suites in the .kunit_test_suites linker section. However, for
kernel modules, a module_init() function is used to run the test suites.
This causes problems if tests are included in a module which already
defines module_init/exit_module functions, as they'll conflict with the
kunit-provided ones.
This change removes the kunit-defined module inits, and instead parses
the kunit tests from their own section in the module. After module init,
we call __kunit_test_suites_init() on the contents of that section,
which prepares and runs the suite.
This essentially unifies the module- and non-module kunit init formats.
Tested-by: Maíra Canal <maira.canal@usp.br>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Signed-off-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'kernel/module')
| -rw-r--r-- | kernel/module/main.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/kernel/module/main.c b/kernel/module/main.c index 4723f1316709..324a770f789c 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -2094,6 +2094,12 @@ static int find_module_sections(struct module *mod, struct load_info *info) sizeof(*mod->static_call_sites), &mod->num_static_call_sites); #endif +#ifdef CONFIG_KUNIT + mod->kunit_suites = section_objs(info, ".kunit_test_suites", + sizeof(*mod->kunit_suites), + &mod->num_kunit_suites); +#endif + mod->extable = section_objs(info, "__ex_table", sizeof(*mod->extable), &mod->num_exentries); |