summaryrefslogtreecommitdiffstats
path: root/kernel/module.c
diff options
context:
space:
mode:
authorMiroslav Benes <mbenes@suse.cz>2020-10-27 15:03:36 +0100
committerJessica Yu <jeyu@kernel.org>2020-10-29 12:29:16 +0100
commit5e8ed280dab9eeabc1ba0b2db5dbe9fe6debb6b5 (patch)
tree63349f6368032e831fd12368d97ed35c06bd9fb2 /kernel/module.c
parent3650b228f83adda7e5ee532e2b90429c03f7b9ec (diff)
downloadlinux-5e8ed280dab9eeabc1ba0b2db5dbe9fe6debb6b5.tar.bz2
module: set MODULE_STATE_GOING state when a module fails to load
If a module fails to load due to an error in prepare_coming_module(), the following error handling in load_module() runs with MODULE_STATE_COMING in module's state. Fix it by correctly setting MODULE_STATE_GOING under "bug_cleanup" label. Signed-off-by: Miroslav Benes <mbenes@suse.cz> Signed-off-by: Jessica Yu <jeyu@kernel.org>
Diffstat (limited to 'kernel/module.c')
-rw-r--r--kernel/module.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/module.c b/kernel/module.c
index a4fa44a652a7..b34235082394 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3991,6 +3991,7 @@ static int load_module(struct load_info *info, const char __user *uargs,
MODULE_STATE_GOING, mod);
klp_module_going(mod);
bug_cleanup:
+ mod->state = MODULE_STATE_GOING;
/* module_bug_cleanup needs module_mutex protection */
mutex_lock(&module_mutex);
module_bug_cleanup(mod);