summaryrefslogtreecommitdiffstats
path: root/ipc
diff options
context:
space:
mode:
authorSylwester Nawrocki <s.nawrocki@samsung.com>2018-06-05 09:33:59 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2018-07-27 13:09:40 -0400
commit4faeaf9c0f4581667ce5826f9c90c4fd463ef086 (patch)
tree2b801a63915033fac99829be838046accf0480d4 /ipc
parent9db3bbf58be59ab496ccd1c7528f4b0e8835c5b1 (diff)
downloadlinux-4faeaf9c0f4581667ce5826f9c90c4fd463ef086.tar.bz2
media: s5p-mfc: Fix buffer look up in s5p_mfc_handle_frame_{new, copy_time} functions
Look up of buffers in s5p_mfc_handle_frame_new, s5p_mfc_handle_frame_copy_time functions is not working properly for DMA addresses above 2 GiB. As a result flags and timestamp of returned buffers are not set correctly and it breaks operation of GStreamer/OMX plugins which rely on the CAPTURE buffer queue flags. Due to improper return type of the get_dec_y_adr, get_dspl_y_adr callbacks and sign bit extension these callbacks return incorrect address values, e.g. 0xfffffffffefc0000 instead of 0x00000000fefc0000. Then the statement: "if (vb2_dma_contig_plane_dma_addr(&dst_buf->b->vb2_buf, 0) == dec_y_addr)" is always false, which breaks looking up capture queue buffers. To ensure proper matching by address u32 type is used for the DMA addresses. This should work on all related SoCs, since the MFC DMA address width is not larger than 32-bit. Changes done in this patch are minimal as there is a larger patch series pending refactoring the whole driver. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'ipc')
0 files changed, 0 insertions, 0 deletions