summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2023-01-11 21:14:26 +0100
committerHans de Goede <hdegoede@redhat.com>2023-01-12 20:10:31 +0100
commitcf5ac2d45f6e4d11ad78e7b10ae9a4121ba5e995 (patch)
treee7b54653708b56c3e057319d1d1a201f05a5a843 /include
parentccb32e2be14271a60e9ba89c6d5660cc9998773c (diff)
downloadlinux-cf5ac2d45f6e4d11ad78e7b10ae9a4121ba5e995.tar.bz2
platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode
acpi_get_and_request_gpiod() does not take a gpio_lookup_flags argument specifying that the pins direction should be initialized to a specific value. This means that in some cases the pins might be left in input mode, causing the gpiod_set() calls made to enable the clk / regulator to not work. One example of this problem is the clk-enable GPIO for the ov01a1s sensor on a Dell Latitude 9420 being left in input mode causing the clk to never get enabled. Explicitly set the direction of the pins to output to fix this. Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> Reviewed-by: Daniel Scally <djrscally@gmail.com> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> Link: https://lore.kernel.org/r/20230111201426.947853-1-hdegoede@redhat.com
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions