diff options
| author | Semen Protsenko <semen.protsenko@globallogic.com> | 2015-01-24 22:28:38 +0200 |
|---|---|---|
| committer | Roger Quadros <rogerq@ti.com> | 2015-02-25 12:47:32 +0200 |
| commit | 9c4f757ee9c64623efec61672305f87452f68968 (patch) | |
| tree | 4c8c85adad625fc62fa7f3c0bc420a2c9a78c137 /include | |
| parent | c517d838eb7d07bbe9507871fab3931deccff539 (diff) | |
| download | linux-9c4f757ee9c64623efec61672305f87452f68968.tar.bz2 | |
ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf
Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
shouldn't be overwritten. A typical approach to handle such bits called
"Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
utilizes RMW technique, but implemented incorrectly. Due to obvious typo
in code read register value is being rewritten by another value, which
leads to loss of read RESERVED bits. This patch fixes this.
While at it, replace magic numbers with named constants to improve code
readability.
Signed-off-by: Semen Protsenko <semen.protsenko@globallogic.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions