summaryrefslogtreecommitdiffstats
path: root/include/trace
diff options
context:
space:
mode:
authorJesper Dangaard Brouer <brouer@redhat.com>2017-08-24 12:33:18 +0200
committerDavid S. Miller <davem@davemloft.net>2017-08-24 11:59:37 -0700
commita873585587205750e7accfb2c93c29239ffa6e09 (patch)
tree3896a9d8cd9c2fb67d06e549e8ff0614beebfbe5 /include/trace
parent2886447dc5add28226451c163cd9ac1d1b3bf59a (diff)
downloadlinux-a873585587205750e7accfb2c93c29239ffa6e09.tar.bz2
xdp: remove net_device names from xdp_redirect tracepoint
There is too much overhead in the current trace_xdp_redirect tracepoint as it does strcpy and strlen on the net_device names. Besides, exposing the ifindex/index is actually the information that is needed in the tracepoint to diagnose issues. When a lookup fails (either ifindex or devmap index) then there is a need for saying which to_index that have issues. V2: Adjust args to be aligned with trace_xdp_exception. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/trace')
-rw-r--r--include/trace/events/xdp.h24
1 files changed, 12 insertions, 12 deletions
diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
index 0e42e69f773b..cd37706c6f55 100644
--- a/include/trace/events/xdp.h
+++ b/include/trace/events/xdp.h
@@ -51,33 +51,33 @@ TRACE_EVENT(xdp_exception,
TRACE_EVENT(xdp_redirect,
- TP_PROTO(const struct net_device *from,
- const struct net_device *to,
- const struct bpf_prog *xdp, u32 act, int err),
+ TP_PROTO(const struct net_device *dev,
+ const struct bpf_prog *xdp, u32 act,
+ int to_index, int err),
- TP_ARGS(from, to, xdp, act, err),
+ TP_ARGS(dev, xdp, act, to_index, err),
TP_STRUCT__entry(
- __string(name_from, from->name)
- __string(name_to, to->name)
__array(u8, prog_tag, 8)
__field(u32, act)
+ __field(int, ifindex)
+ __field(int, to_index)
__field(int, err)
),
TP_fast_assign(
BUILD_BUG_ON(sizeof(__entry->prog_tag) != sizeof(xdp->tag));
memcpy(__entry->prog_tag, xdp->tag, sizeof(xdp->tag));
- __assign_str(name_from, from->name);
- __assign_str(name_to, to->name);
- __entry->act = act;
- __entry->err = err;
+ __entry->act = act;
+ __entry->ifindex = dev->ifindex;
+ __entry->to_index = to_index;
+ __entry->err = err;
),
- TP_printk("prog=%s from=%s to=%s action=%s err=%d",
+ TP_printk("prog=%s action=%s ifindex=%d to_index=%d err=%d",
__print_hex_str(__entry->prog_tag, 8),
- __get_str(name_from), __get_str(name_to),
__print_symbolic(__entry->act, __XDP_ACT_SYM_TAB),
+ __entry->ifindex, __entry->to_index,
__entry->err)
);
#endif /* _TRACE_XDP_H */