diff options
author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2017-05-23 22:40:42 +0900 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2017-05-24 23:49:38 +0200 |
commit | 6dbaf8b913f2976ee776beb7c8bb0c52c7066ced (patch) | |
tree | 2dbc0f42bcea076438a98e9064d3344908865408 /include/sound/wm8955.h | |
parent | 097a7fe369421347405d448a5ee1d37087cad4ad (diff) | |
download | linux-6dbaf8b913f2976ee776beb7c8bb0c52c7066ced.tar.bz2 |
ALSA: sb: remove needless evaluation in implementation for copy callback
In design of ALSA pcm core, 'struct snd_pcm_ops.copy' is expected to
copy PCM frames, according to frame alignment on intermediate buffer for
userspace and dedicated buffer for data transmission. In this callback,
value of 'channel' argument depends on the frame alignment, which drivers
registers to runtime of PCM substream. When target devices can handle
non-interleaved buffer, this value has positive value, otherwise negative.
ALSA driver for PCM component of EMU8000 chip is programmed with local
macro to switch the frame alignment. The 'copy' operation in
non-interleaved side has evaluation of the 'channel' argument (actually
it's 'voice' argument). This is useless.
This commit remove the evaluation.
[tiwai: the negative channel argument was the inheritance from the old
code where -1 was meant for interleaved mode. The mix-up was dropped
meanwhile, thus it's correct to assume that we receive no longer -1
there, and it's safe to cleanup the relevant code.
Also, voice=0 for channel==1 is trivial, and it can be dropped, too.]
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound/wm8955.h')
0 files changed, 0 insertions, 0 deletions