diff options
| author | Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> | 2019-07-25 12:07:12 -0600 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-07-26 14:20:06 -0700 |
| commit | a7cf3d24ee6081930feb4c830a7f6f16ebe31c49 (patch) | |
| tree | c48c6b6df8e7a7e7f7f53c59d090ebccc7103651 /include/linux/if_rmnet.h | |
| parent | 01f5bffad555f8e22a61f4b1261fe09cf1b96994 (diff) | |
| download | linux-a7cf3d24ee6081930feb4c830a7f6f16ebe31c49.tar.bz2 | |
net: qualcomm: rmnet: Fix incorrect UL checksum offload logic
The udp_ip4_ind bit is set only for IPv4 UDP non-fragmented packets
so that the hardware can flip the checksum to 0xFFFF if the computed
checksum is 0 per RFC768.
However, this bit had to be set for IPv6 UDP non fragmented packets
as well per hardware requirements. Otherwise, IPv6 UDP packets
with computed checksum as 0 were transmitted by hardware and were
dropped in the network.
In addition to setting this bit for IPv6 UDP, the field is also
appropriately renamed to udp_ind as part of this change.
Fixes: 5eb5f8608ef1 ("net: qualcomm: rmnet: Add support for TX checksum offload")
Cc: Sean Tranchetti <stranche@codeaurora.org>
Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/if_rmnet.h')
| -rw-r--r-- | include/linux/if_rmnet.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/if_rmnet.h b/include/linux/if_rmnet.h index b4f5403383fc..9661416a9bb4 100644 --- a/include/linux/if_rmnet.h +++ b/include/linux/if_rmnet.h @@ -41,11 +41,11 @@ struct rmnet_map_ul_csum_header { __be16 csum_start_offset; #if defined(__LITTLE_ENDIAN_BITFIELD) u16 csum_insert_offset:14; - u16 udp_ip4_ind:1; + u16 udp_ind:1; u16 csum_enabled:1; #elif defined (__BIG_ENDIAN_BITFIELD) u16 csum_enabled:1; - u16 udp_ip4_ind:1; + u16 udp_ind:1; u16 csum_insert_offset:14; #else #error "Please fix <asm/byteorder.h>" |