diff options
author | Yang Yingliang <yangyingliang@huawei.com> | 2022-11-08 20:13:16 +0800 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2022-12-07 13:22:35 +0100 |
commit | a525cad241c339ca00bf7ebf03c5180f2a9b767c (patch) | |
tree | c558a531e03509149906bd620b6d5c537ed2411b /fs/signalfd.c | |
parent | 9e6e8c43726673ca2abcaac87640b9215fd72f4c (diff) | |
download | linux-a525cad241c339ca00bf7ebf03c5180f2a9b767c.tar.bz2 |
mmc: omap_hsmmc: fix return value check of mmc_add_host()
mmc_add_host() may return error, if we ignore its return value,
it will lead two issues:
1. The memory that allocated in mmc_alloc_host() is leaked.
2. In the remove() path, mmc_remove_host() will be called to
delete device, but it's not added yet, it will lead a kernel
crash because of null-ptr-deref in device_del().
Fix this by checking the return value and goto error path wihch
will call mmc_free_host().
Fixes: a45c6cb81647 ("[ARM] 5369/1: omap mmc: Add new omap hsmmc controller for 2430 and 34xx, v3")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221108121316.340354-1-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'fs/signalfd.c')
0 files changed, 0 insertions, 0 deletions