diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-11-20 11:56:07 +0100 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-11-21 11:03:31 +0100 |
commit | 92ec07677107974c31b32030a4f897398e452ca9 (patch) | |
tree | c820e36349d08240f22e3afa6ecf67f761a0c1aa /fs/nfsd/trace.c | |
parent | fedf7a441fe89d17907218f6cd53975a9a929837 (diff) | |
download | linux-92ec07677107974c31b32030a4f897398e452ca9.tar.bz2 |
drm/msm: Don't init ww_mutec acquire ctx before needed
For locking semantics it really doesn't matter when we grab the
ticket. But for lockdep validation it does: the acquire ctx is a fake
lockdep. Since other drivers might want to do a full multi-lock dance
in their fault-handler, not just lock a single dma_resv. Therefore we
must init the acquire_ctx only after we've done all the copy_*_user or
anything else that might trigger a pagefault. For msm this means we
need to move it past submit_lookup_objects.
Aside: Why is msm still using struct_mutex, it seems to be using
dma_resv_lock for general buffer state protection?
v2:
- Add comment to explain why the ww ticket setup is separate (Rob)
- Fix up error handling, we need to make sure we don't call
ww_acquire_fini without _init.
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-and-tested-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Link: https://patchwork.freedesktop.org/patch/msgid/20191120105607.3023-1-daniel.vetter@ffwll.ch
Diffstat (limited to 'fs/nfsd/trace.c')
0 files changed, 0 insertions, 0 deletions