diff options
| author | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-09-20 10:50:17 -0400 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-09-20 22:34:16 -0400 |
| commit | 24311f884189d42d40354a6f38ca218eb9aeb811 (patch) | |
| tree | 298a5debe9cfe0397ce289f10e6bf533fe5f8df4 /fs/nfs/callback_proc.c | |
| parent | 8714d46dc5b95a6a898ec8f1e67237c7995adfc6 (diff) | |
| download | linux-24311f884189d42d40354a6f38ca218eb9aeb811.tar.bz2 | |
NFSv4: Recovery of recalled read delegations is broken
When a read delegation is being recalled, and we're reclaiming the
cached opens, we need to make sure that we only reclaim read-only
modes.
A previous attempt to do this, relied on retrieving the delegation
type from the nfs4_opendata structure. Unfortunately, as Kinglong
pointed out, this field can only be set when performing reboot recovery.
Furthermore, if we call nfs4_open_recover(), then we end up clobbering
the state->flags for all modes that we're not recovering...
The fix is to have the delegation recall code pass this information
to the recovery call, and then refactor the recovery code so that
nfs4_open_delegation_recall() does not need to call nfs4_open_recover().
Reported-by: Kinglong Mee <kinglongmee@gmail.com>
Fixes: 39f897fdbd46 ("NFSv4: When returning a delegation, don't...")
Tested-by: Kinglong Mee <kinglongmee@gmail.com>
Cc: NeilBrown <neilb@suse.com>
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/nfs/callback_proc.c')
0 files changed, 0 insertions, 0 deletions