summaryrefslogtreecommitdiffstats
path: root/fs/lockd/svc.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2018-02-14 12:15:06 +1100
committerJ. Bruce Fields <bfields@redhat.com>2018-03-19 16:38:12 -0400
commit3b68e6ee3cbd4a474bcc7d2ac26812f86cdf333d (patch)
tree3a5eeb2a6b2f87e3d381022ae20e33856f89a97d /fs/lockd/svc.c
parent90a9b1473df72a8b356e7ad6c9b9c9608927b103 (diff)
downloadlinux-3b68e6ee3cbd4a474bcc7d2ac26812f86cdf333d.tar.bz2
SUNRPC: cache: ignore timestamp written to 'flush' file.
The interface for flushing the sunrpc auth cache was poorly designed and has caused problems a number of times. The design is that you write a timestamp, and all entries created before that time are discarded. The most obvious problem is that this is not what people actually want. They want to just flush the whole cache. The 1-second granularity can be a problem, as can the use of wall-clock time. A current problem is that code will write the current time to this file - expecting it to clear everything - and if the seconds number ticks over before this timestamp is checked, the test "then >= now" fails, and a full flush isn't forced. So lets just drop the subtleties and always flush the whole cache. The worst this could do is impose an extra cost refilling it, but that would require someone to be using non-standard tools. We still report an error if the string written is not a number, but we cause any valid number to flush the whole cache. Reported-by: "Wang, Alan 1. (NSB - CN/Hangzhou)" <alan.1.wang@nokia-sbell.com> Signed-off-by: NeilBrown <neilb@suse.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/lockd/svc.c')
0 files changed, 0 insertions, 0 deletions