diff options
| author | Xiu Jianfeng <xiujianfeng@huawei.com> | 2022-11-16 20:22:37 +0800 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2022-12-11 08:33:31 -0600 |
| commit | bc044414fa0326a4e5c3c509c00b1fcaf621b5f4 (patch) | |
| tree | 47c84c8187124ab9480207df68f410259f846090 /fs/ksmbd | |
| parent | 30429388531b120902126a39cf64f877fc5c7773 (diff) | |
| download | linux-bc044414fa0326a4e5c3c509c00b1fcaf621b5f4.tar.bz2 | |
ksmbd: Fix resource leak in ksmbd_session_rpc_open()
When ksmbd_rpc_open() fails then it must call ksmbd_rpc_id_free() to
undo the result of ksmbd_ipc_id_alloc().
Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/ksmbd')
| -rw-r--r-- | fs/ksmbd/mgmt/user_session.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/fs/ksmbd/mgmt/user_session.c b/fs/ksmbd/mgmt/user_session.c index 3fa2139a0b30..92b1603b5abe 100644 --- a/fs/ksmbd/mgmt/user_session.c +++ b/fs/ksmbd/mgmt/user_session.c @@ -108,15 +108,17 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name) entry->method = method; entry->id = ksmbd_ipc_id_alloc(); if (entry->id < 0) - goto error; + goto free_entry; resp = ksmbd_rpc_open(sess, entry->id); if (!resp) - goto error; + goto free_id; kvfree(resp); return entry->id; -error: +free_id: + ksmbd_rpc_id_free(entry->id); +free_entry: list_del(&entry->list); kfree(entry); return -EINVAL; |