diff options
| author | Anand Jain <anand.jain@oracle.com> | 2020-02-12 17:28:12 +0800 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2020-03-23 17:01:35 +0100 |
| commit | 1f6087e69c73b2ce8f1c20a4199488d937bb6b67 (patch) | |
| tree | e233fdfa6cc36b719022ffc89659351960954fea /fs/btrfs | |
| parent | f657a31c8667a4d06551e308c1af9ed0b02129f4 (diff) | |
| download | linux-1f6087e69c73b2ce8f1c20a4199488d937bb6b67.tar.bz2 | |
btrfs: sysfs, use btrfs_sysfs_remove_fsid to celanup errors in add_fsid
We have one simple function btrfs_sysfs_remove_fsid() to undo
btrfs_sysfs_add_fsid(), which also does proper checks before releasing
objects.
One difference, if btrfs_sysfs_remove_fsid is used that now we also call
kobject_del() which was missing before. This was tested (with kobject
debug turned on) and no change in behaviour was found.
This is a cleanup patch.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3c10e78924d0..119edd4341d6 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -1371,7 +1371,7 @@ int btrfs_sysfs_add_fsid(struct btrfs_fs_devices *fs_devs) if (!fs_devs->devices_kobj) { btrfs_err(fs_devs->fs_info, "failed to init sysfs device interface"); - kobject_put(&fs_devs->fsid_kobj); + btrfs_sysfs_remove_fsid(fs_devs); return -ENOMEM; } |