summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/backref.c
diff options
context:
space:
mode:
authorAnand Jain <anand.jain@oracle.com>2022-11-07 23:07:17 +0800
committerDavid Sterba <dsterba@suse.com>2022-12-05 18:00:55 +0100
commitbb21e30260a672172a26ee1626dc1463215cf18c (patch)
tree7c3beb014c5ec7888214289e24a59f5604af2c03 /fs/btrfs/backref.c
parent3e09b5b2293f21e6e28929b6bbb73833678bfdd1 (diff)
downloadlinux-bb21e30260a672172a26ee1626dc1463215cf18c.tar.bz2
btrfs: move device->name RCU allocation and assign to btrfs_alloc_device()
There is a repeating code section in the parent function after calling btrfs_alloc_device(), as below: name = rcu_string_strdup(path, GFP_...); if (!name) { btrfs_free_device(device); return ERR_PTR(-ENOMEM); } rcu_assign_pointer(device->name, name); Except in add_missing_dev() for obvious reasons. This patch consolidates that repeating code into the btrfs_alloc_device() itself so that the parent function doesn't have to duplicate code. This consolidation also helps to review issues regarding RCU lock violation with device->name. Parent function device_list_add() and add_missing_dev() use GFP_NOFS for the allocation, whereas the rest of the parent functions use GFP_KERNEL, so bring the NOFS allocation context using memalloc_nofs_save() in the function device_list_add() and add_missing_dev() is already doing it. Signed-off-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/backref.c')
0 files changed, 0 insertions, 0 deletions