summaryrefslogtreecommitdiffstats
path: root/firmware
diff options
context:
space:
mode:
authorMatthias Schiffer <mschiffer@universe-factory.net>2018-01-23 10:59:49 +0100
committerSimon Wunderlich <sw@simonwunderlich.de>2018-02-25 20:00:44 +0100
commitabd6360591d3f8259f41c34e31ac4826dfe621b8 (patch)
treeb17c584aa8171f5001468f6932c3c7c6deb89696 /firmware
parent7928b2cbe55b2a410a0f5c1f154610059c57b1b2 (diff)
downloadlinux-abd6360591d3f8259f41c34e31ac4826dfe621b8.tar.bz2
batman-adv: fix packet checksum in receive path
eth_type_trans() internally calls skb_pull(), which does not adjust the skb checksum; skb_postpull_rcsum() is necessary to avoid log spam of the form "bat0: hw csum failure" when packets with CHECKSUM_COMPLETE are received. Note that in usual setups, packets don't reach batman-adv with CHECKSUM_COMPLETE (I assume NICs bail out of checksumming when they see batadv's ethtype?), which is why the log messages do not occur on every system using batman-adv. I could reproduce this issue by stacking batman-adv on top of a VXLAN interface. Fixes: c6c8fea29769 ("net: Add batman-adv meshing protocol") Tested-by: Maximilian Wilhelm <max@sdn.clinic> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'firmware')
0 files changed, 0 insertions, 0 deletions