summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorYiPeng Chai <YiPeng.Chai@amd.com>2022-08-12 14:34:35 +0800
committerAlex Deucher <alexander.deucher@amd.com>2022-08-19 17:06:21 -0400
commitf5994da72ba124a3d0463672fdfbec073e3bb72f (patch)
tree94e61261c92c63570fef038e6bc60a2aac670633 /drivers
parent9d705d7741ae70764f3d6d87e67fad3b5c30ffd0 (diff)
downloadlinux-f5994da72ba124a3d0463672fdfbec073e3bb72f.tar.bz2
drm/amdgpu: fix hive reference leak when adding xgmi device
Only amdgpu_get_xgmi_hive but no amdgpu_put_xgmi_hive which will leak the hive reference. Signed-off-by: YiPeng Chai <YiPeng.Chai@amd.com> Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/gpu/drm/amd/amdgpu/amdgpu_device.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index e8a0b19b7398..95ce3687902b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2456,12 +2456,14 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)
if (!hive->reset_domain ||
!amdgpu_reset_get_reset_domain(hive->reset_domain)) {
r = -ENOENT;
+ amdgpu_put_xgmi_hive(hive);
goto init_failed;
}
/* Drop the early temporary reset domain we created for device */
amdgpu_reset_put_reset_domain(adev->reset_domain);
adev->reset_domain = hive->reset_domain;
+ amdgpu_put_xgmi_hive(hive);
}
}