diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-10-25 17:31:14 +0800 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-11-25 10:56:48 -0600 |
| commit | e8d68f88bcb4e336b308a05d1389e999f0b0c4b0 (patch) | |
| tree | 0c46b419038619defbeae0fe2bbc8bcf6b395512 /drivers | |
| parent | a535d81c92615b8ffb99b7e1fd1fb01effaed1af (diff) | |
| download | linux-e8d68f88bcb4e336b308a05d1389e999f0b0c4b0.tar.bz2 | |
usb: phy: phy-generic: fix return value check in usb_nop_xceiv_register()
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/phy/phy-generic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index 2d135b09c051..aa6d37b3378a 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -48,8 +48,9 @@ void usb_nop_xceiv_register(void) if (pd) return; pd = platform_device_register_simple("usb_phy_gen_xceiv", -1, NULL, 0); - if (!pd) { + if (IS_ERR(pd)) { pr_err("Unable to register generic usb transceiver\n"); + pd = NULL; return; } } |