summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2015-01-04 17:28:27 +0200
committerMichael S. Tsirkin <mst@redhat.com>2015-01-06 16:35:36 +0200
commita1eb03f546d651a8f39c7d0692b1f7f5b4e7e3cd (patch)
tree5c13bec69e729fef992d61b9acaa0710aac6f6b7 /drivers
parent63bd62a08ca45a0c804c3c89777edc7f76a2d6da (diff)
downloadlinux-a1eb03f546d651a8f39c7d0692b1f7f5b4e7e3cd.tar.bz2
virtio_pci: document why we defer kfree
The reason we defer kfree until release function is because it's a general rule for kobjects: kfree of the reference counter itself is only legal in the release function. Previous patch didn't make this clear, document this in code. Cc: stable@vger.kernel.org Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/virtio/virtio_pci_legacy.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
index 4beaee384906..a5486e65e04b 100644
--- a/drivers/virtio/virtio_pci_legacy.c
+++ b/drivers/virtio/virtio_pci_legacy.c
@@ -216,6 +216,9 @@ static void virtio_pci_release_dev(struct device *_d)
struct virtio_device *vdev = dev_to_virtio(_d);
struct virtio_pci_device *vp_dev = to_vp_device(vdev);
+ /* As struct device is a kobject, it's not safe to
+ * free the memory (including the reference counter itself)
+ * until it's release callback. */
kfree(vp_dev);
}