diff options
| author | Oded Gabbay <ogabbay@kernel.org> | 2022-06-05 12:56:36 +0300 |
|---|---|---|
| committer | Oded Gabbay <ogabbay@kernel.org> | 2022-07-12 09:09:22 +0300 |
| commit | 8742a75a1c3f4c93efedfa5004d18c87e467ca3b (patch) | |
| tree | 532baf3fa3726f091e9fc40dde2f0b1744b6533f /drivers | |
| parent | d0c92afc0ef826932937a27a973d7d024e98be18 (diff) | |
| download | linux-8742a75a1c3f4c93efedfa5004d18c87e467ca3b.tar.bz2 | |
habanalabs/gaudi: fix comment to reflect current code
Due to code changes in the past few years, the original comment of
how parser->user_cb_size is checked was not correct anymore.
Fix it to reflect current code and add more explanation as the code
is more complex now.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/misc/habanalabs/gaudi/gaudi.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index c16c0f9fe202..72b0d145e853 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -5562,8 +5562,14 @@ static int gaudi_parse_cb_mmu(struct hl_device *hdev, } /* - * The check that parser->user_cb_size <= parser->user_cb->size was done - * in validate_queue_index(). + * We are protected from overflow because the check + * "parser->user_cb_size <= parser->user_cb->size" was done in get_cb_from_cs_chunk() + * in the common code. That check is done only if is_kernel_allocated_cb is true. + * + * There is no option to reach here without going through that check because: + * 1. validate_queue_index() assigns true to is_kernel_allocated_cb for any submission to + * an external queue. + * 2. For Gaudi, we only parse CBs that were submitted to the external queues. */ memcpy(parser->patched_cb->kernel_address, parser->user_cb->kernel_address, |