diff options
author | Xin Long <lucien.xin@gmail.com> | 2017-05-19 22:20:29 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-05-21 13:33:28 -0400 |
commit | 6d18c732b95c0a9d35e9f978b4438bba15412284 (patch) | |
tree | ea7f0f25f26987d4993dadb8db7c9f2fb05bfa2b /drivers | |
parent | fe0cd8ca1b82983db24b173bb8518ea646c02d25 (diff) | |
download | linux-6d18c732b95c0a9d35e9f978b4438bba15412284.tar.bz2 |
bridge: start hello_timer when enabling KERNEL_STP in br_stp_start
Since commit 76b91c32dd86 ("bridge: stp: when using userspace stp stop
kernel hello and hold timers"), bridge would not start hello_timer if
stp_enabled is not KERNEL_STP when br_dev_open.
The problem is even if users set stp_enabled with KERNEL_STP later,
the timer will still not be started. It causes that KERNEL_STP can
not really work. Users have to re-ifup the bridge to avoid this.
This patch is to fix it by starting br->hello_timer when enabling
KERNEL_STP in br_stp_start.
As an improvement, it's also to start hello_timer again only when
br->stp_enabled is KERNEL_STP in br_hello_timer_expired, there is
no reason to start the timer again when it's NO_STP.
Fixes: 76b91c32dd86 ("bridge: stp: when using userspace stp stop kernel hello and hold timers")
Reported-by: Haidong Li <haili@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Reviewed-by: Ivan Vecera <cera@cera.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions