diff options
| author | Tommie Gannert <tommie@gannert.se> | 2014-02-17 20:46:04 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-02-17 16:27:51 -0500 |
| commit | 3eca5299532ea9d6ab63b03e7aaac9071d5eed29 (patch) | |
| tree | 42e6edb9b485064b25e508c662b62f288dfed318 /drivers | |
| parent | 163c8ff30dbe473abfbb24a7eac5536c87f3baa9 (diff) | |
| download | linux-3eca5299532ea9d6ab63b03e7aaac9071d5eed29.tar.bz2 | |
irtty-sir.c: Do not set_termios() on irtty_close()
Issuing set_termios() from irtty_close() causes kernel Oops for
unplugged usb-serial devices.
Since no other tty_ldisc calls set_termios() on close and no tty driver
seem to check if tty->device_data is NULL or not on entry to set_termios(),
the only solution I can come up with is to remove the irtty_stop_receiver()
call, which only updates termios.
Signed-off-by: Tommie Gannert <tommie@gannert.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/irda/irtty-sir.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/irda/irtty-sir.c b/drivers/net/irda/irtty-sir.c index 177441afeb96..24b6dddd7f2f 100644 --- a/drivers/net/irda/irtty-sir.c +++ b/drivers/net/irda/irtty-sir.c @@ -522,7 +522,6 @@ static void irtty_close(struct tty_struct *tty) sirdev_put_instance(priv->dev); /* Stop tty */ - irtty_stop_receiver(tty, TRUE); clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags); if (tty->ops->stop) tty->ops->stop(tty); |