diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-06-22 21:37:48 +0200 |
|---|---|---|
| committer | Peter Chen <peter.chen@zeku.com> | 2021-07-29 14:28:15 +0800 |
| commit | 5df09c15bab98463203c83ecab88b9321466e626 (patch) | |
| tree | ba5a83fa4a00a242369568e56873fc53c08cfae5 /drivers/usb/cdns3 | |
| parent | e913aada06830338633fb8524733b0ad3d38a7c1 (diff) | |
| download | linux-5df09c15bab98463203c83ecab88b9321466e626.tar.bz2 | |
usb: cdnsp: Fix the IMAN_IE_SET and IMAN_IE_CLEAR macro
IMAN_IE is BIT(1), so these macro are respectively equivalent to BIT(1)
and 0, whatever the value of 'p'.
The purpose was to set and reset a single bit in 'p'.
Fix these macros to do that correctly.
Acked-by: Pawel Laszczak <pawell@cadence.com>
Fixes: e93e58d27402 ("usb: cdnsp: Device side header file for CDNSP driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/d12bfcc9cbffb89e27b120668821b3c4f09b6755.1624390584.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Peter Chen <peter.chen@kernel.org>
Diffstat (limited to 'drivers/usb/cdns3')
| -rw-r--r-- | drivers/usb/cdns3/cdnsp-gadget.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/cdns3/cdnsp-gadget.h b/drivers/usb/cdns3/cdnsp-gadget.h index 783ca8ffde00..f740fa6089d8 100644 --- a/drivers/usb/cdns3/cdnsp-gadget.h +++ b/drivers/usb/cdns3/cdnsp-gadget.h @@ -383,8 +383,8 @@ struct cdnsp_intr_reg { #define IMAN_IE BIT(1) #define IMAN_IP BIT(0) /* bits 2:31 need to be preserved */ -#define IMAN_IE_SET(p) (((p) & IMAN_IE) | 0x2) -#define IMAN_IE_CLEAR(p) (((p) & IMAN_IE) & ~(0x2)) +#define IMAN_IE_SET(p) ((p) | IMAN_IE) +#define IMAN_IE_CLEAR(p) ((p) & ~IMAN_IE) /* IMOD - Interrupter Moderation Register - irq_control bitmasks. */ /* |